Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list_action_button_content and logo_content options #7325

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Add list_action_button_content and logo_content options #7325

merged 1 commit into from
Jul 19, 2021

Conversation

VincentLanglet
Copy link
Member

@VincentLanglet VincentLanglet commented Jul 14, 2021 •
edited
Loading

Subject

BC

I take in account the review from #7166

Closes #6970

Changelog

### Added
- Option `list_action_button_content`.

### Deprecated
- Option `title_mode`. Use `logo_content` instead.

@VincentLanglet VincentLanglet force-pushed the buttonContent branch 3 times, most recently from c2f627d to 5315ab1 Compare July 14, 2021 18:24
@VincentLanglet VincentLanglet marked this pull request as ready for review July 14, 2021 18:24
@VincentLanglet VincentLanglet requested a review from a team July 14, 2021 18:24
@VincentLanglet VincentLanglet mentioned this pull request Jul 14, 2021
Closed
@VincentLanglet
Copy link
Member Author

Please review @sonata-project/contributors , then I'll do the 3.104 release :)

@VincentLanglet VincentLanglet mentioned this pull request Jul 19, 2021
Merged
jordisala1991
jordisala1991 previously approved these changes Jul 19, 2021
View reviewed changes
@VincentLanglet VincentLanglet requested a review from phansys July 19, 2021 23:04
@VincentLanglet
Copy link
Member Author

I updated the logic @phansys, do you prefer this way ?

@phansys
Copy link
Member

phansys commented Jul 19, 2021

Thank you! It is consistent with what we have in other similar cases.

@phansys phansys requested a review from jordisala1991 July 19, 2021 23:13
@VincentLanglet VincentLanglet merged commit dfb8bdc into sonata-project:3.x Jul 19, 2021
@VincentLanglet VincentLanglet deleted the buttonContent branch July 19, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys approved these changes

@franmomu franmomu Awaiting requested review from franmomu

@dmaicher dmaicher Awaiting requested review from dmaicher

@jordisala1991 jordisala1991 Awaiting requested review from jordisala1991

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to get small link_action buttons.
3 participants
@VincentLanglet @phansys @jordisala1991